ctubbsii commented on a change in pull request #2143:
URL: https://github.com/apache/accumulo/pull/2143#discussion_r645063993
##########
File path: core/src/main/java/org/apache/accumulo/core/conf/Property.java
##########
@@ -1045,40 +1045,44 @@
"The maximum size of a message that can be sent to a tablet server."),
// CompactionCoordinator properties
@Experimental
- COORDINATOR_PREFIX("coordinator.", null, PropertyType.PREFIX,
+ COMPACTION_COORDINATOR_PREFIX("compaction_coordinator.", null,
PropertyType.PREFIX,
Review comment:
I like `compaction.coordinator` with `compaction.worker` better than I
like `compaction-coordinator` and `compactor`, and I like that one slightly
better than `compactionCoordinator` and `compactor`.
You're right there's no precedent for use of dash for property keys in our
code. Additionally, a quick Google search for dashes in config keys resulted in
several discussions about constraints and even some bugs in Spring, ConfigJSR
(JSR-382), and other configuration systems. One of the popular issues was that
some of these systems try provide ways to use configuration properties as
environment variables, and you can't use dashes in environment variables in
Linux. Those projects seemed to try workarounds that involved fuzzy matching,
but those solutions struggled with internationalization issues. For us, I think
it's probably just best to avoid dashes in our keys, to ensure flexibility in
future for our configuration keys, and to avoid pitfalls that others have
experienced.
Dots seem to be the preferred delimiter for config files. Underscores seem
to be borrowing from a different naming convention. I would stick with dots or
none.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
