dlmarion commented on a change in pull request #2143:
URL: https://github.com/apache/accumulo/pull/2143#discussion_r645073131



##########
File path: core/src/main/java/org/apache/accumulo/core/conf/Property.java
##########
@@ -1045,40 +1045,44 @@
       "The maximum size of a message that can be sent to a tablet server."),
   // CompactionCoordinator properties
   @Experimental
-  COORDINATOR_PREFIX("coordinator.", null, PropertyType.PREFIX,
+  COMPACTION_COORDINATOR_PREFIX("compaction_coordinator.", null, 
PropertyType.PREFIX,

Review comment:
       This is reminding me of the "just add the dot" episode from years ago. 
I'll modify `compaction_coordinator` to use the dot in the key instead of the 
underscore. I'd rather not change `compactor` to `compaction.worker` as I am 
under the impression (maybe mistakenly) that the first part of the property 
name for processes should be the process name (`manager`, `gc`, `tserver`, 
`monitor`, etc).




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to