dlmarion commented on a change in pull request #2143:
URL: https://github.com/apache/accumulo/pull/2143#discussion_r645047747
##########
File path: core/src/main/java/org/apache/accumulo/core/conf/Property.java
##########
@@ -1045,40 +1045,44 @@
"The maximum size of a message that can be sent to a tablet server."),
// CompactionCoordinator properties
@Experimental
- COORDINATOR_PREFIX("coordinator.", null, PropertyType.PREFIX,
+ COMPACTION_COORDINATOR_PREFIX("compaction_coordinator.", null,
PropertyType.PREFIX,
Review comment:
My initial inclination was to use a `-` (dash), but could not find an
example of this being done elsewhere. I would rather see
`compaction-coordinator` vs `compaction.coordinator`.
I guess another convention that's not mentioned is to use the first letter
and second word in a multi-word server name (tablet server -> tserver). I
suppose I could use `ccoordinator`
(just kidding)
##########
File path: core/src/main/java/org/apache/accumulo/core/conf/Property.java
##########
@@ -1045,40 +1045,44 @@
"The maximum size of a message that can be sent to a tablet server."),
// CompactionCoordinator properties
@Experimental
- COORDINATOR_PREFIX("coordinator.", null, PropertyType.PREFIX,
+ COMPACTION_COORDINATOR_PREFIX("compaction_coordinator.", null,
PropertyType.PREFIX,
Review comment:
This is reminding me of the "just add the dot" episode from years ago.
I'll modify `compaction_coordinator` to use the dot in the key instead of the
underscore. I'd rather not change `compactor` to `compaction.worker` as I am
under the impression (maybe mistakenly) that the first part of the property
name for processes should be the process name (`manager`, `gc`, `tserver`,
`monitor`, etc).
##########
File path: core/src/main/java/org/apache/accumulo/core/conf/Property.java
##########
@@ -1045,40 +1045,44 @@
"The maximum size of a message that can be sent to a tablet server."),
// CompactionCoordinator properties
@Experimental
- COORDINATOR_PREFIX("coordinator.", null, PropertyType.PREFIX,
+ COMPACTION_COORDINATOR_PREFIX("compaction_coordinator.", null,
PropertyType.PREFIX,
Review comment:
Changing to the dot fails PropertyTest:
```
java.lang.AssertionError: Invalid prefix on prop
compaction.coordinator.port.client
at org.junit.Assert.fail(Assert.java:89)
at org.junit.Assert.assertTrue(Assert.java:42)
at
org.apache.accumulo.core.conf.PropertyTest.testProperties(PropertyTest.java:75)
```
##########
File path: core/src/main/java/org/apache/accumulo/core/conf/Property.java
##########
@@ -1045,40 +1045,44 @@
"The maximum size of a message that can be sent to a tablet server."),
// CompactionCoordinator properties
@Experimental
- COORDINATOR_PREFIX("coordinator.", null, PropertyType.PREFIX,
+ COMPACTION_COORDINATOR_PREFIX("compaction_coordinator.", null,
PropertyType.PREFIX,
Review comment:
(deleted) - I missed one
##########
File path: core/src/main/java/org/apache/accumulo/core/conf/Property.java
##########
@@ -1045,40 +1045,44 @@
"The maximum size of a message that can be sent to a tablet server."),
// CompactionCoordinator properties
@Experimental
- COORDINATOR_PREFIX("coordinator.", null, PropertyType.PREFIX,
+ COMPACTION_COORDINATOR_PREFIX("compaction_coordinator.", null,
PropertyType.PREFIX,
Review comment:
`compaction_coordinator` changed to `compaction.coordinator` in cce4e6c
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
