milleruntime commented on a change in pull request #2185:
URL: https://github.com/apache/accumulo/pull/2185#discussion_r666061369
##########
File path: server/manager/src/main/java/org/apache/accumulo/manager/Manager.java
##########
@@ -1120,6 +1122,9 @@ boolean canSuspendTablets() {
if (null != upgradeMetadataFuture) {
upgradeMetadataFuture.get();
}
+ if (null != upgradeFilesFuture) {
+ upgradeFilesFuture.get();
+ }
Review comment:
Correct, it doesn't matter in this case. But I did have the same
concerns about future problems with the upgrader. Since I didn't have a
concrete example, I wasn't sure when `upgradeFiles()` should get called. I
ended up settling with this concurrent upgrade since that works for the current
changes.
Any thoughts on where in the upgrade order the files would ideally get
upgraded? I was originally thinking last, after the metadata. Maybe the files
should be done first before anything (but after ZK?) so we know what paths to
store? Like I said, I couldn't think of any specific upgrade example where
files were dependent on other changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
