milleruntime commented on a change in pull request #2185:
URL: https://github.com/apache/accumulo/pull/2185#discussion_r666106221
##########
File path:
server/manager/src/main/java/org/apache/accumulo/manager/upgrade/Upgrader9to10.java
##########
@@ -144,6 +150,11 @@ public void upgradeMetadata(ServerContext ctx) {
upgradeFileDeletes(ctx, Ample.DataLevel.USER);
}
+ @Override
+ public void upgradeFiles(ServerContext ctx) {
+ dropSortedMapWALFiles(ctx.getVolumeManager());
Review comment:
> What happens when we delete these files?
Accumulo will automatically re-sort the WALs based off of the original files
in `/accumulo/wal`.
> Wouldn't sorted files have references in the metadata tables?
No they do not. The references are stored in ZK and hdfs. The
`DistributedWorkQueue` runs the `LogSorter` based on data in the ZK node. Each
node is populated based on the WAL filename/ID taken from `/accumulo/wal`. This
method only deletes the temporary sorted files in `/accumulo/recovery`.
> Is it safe to just remove these and Accumulo will just recreate them using
the new format?
Yes that is the intent. Without this change, Accumulo won't be able to
recovery tablets in the old map files. If it happens that metadata tablets are
in these old sorted map files, then Accumulo won't be able to start.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
