ctubbsii commented on a change in pull request #2185:
URL: https://github.com/apache/accumulo/pull/2185#discussion_r678572102
##########
File path: server/manager/src/main/java/org/apache/accumulo/manager/Manager.java
##########
@@ -1120,6 +1122,9 @@ boolean canSuspendTablets() {
if (null != upgradeMetadataFuture) {
upgradeMetadataFuture.get();
}
+ if (null != upgradeFilesFuture) {
+ upgradeFilesFuture.get();
+ }
Review comment:
I think it's probably okay to upgrade the files at manager startup
through this mechanism. The part I'm concerned about is changing the upgrade
interface to provide a general mechanism to upgrade files, as that could
encourage misuse. Maybe we can just consider these part of the "metadata" and
perform the upgrade there instead of add the new "upgradeFiles" stuff?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
