milleruntime commented on a change in pull request #2197:
URL: https://github.com/apache/accumulo/pull/2197#discussion_r675108757



##########
File path: 
server/base/src/main/java/org/apache/accumulo/server/ServerContext.java
##########
@@ -65,7 +67,8 @@
   private DefaultConfiguration defaultConfig = null;
   private AccumuloConfiguration systemConfig = null;
   private AuthenticationTokenSecretManager secretManager;
-  private CryptoService cryptoService = null;
+  private CryptoService walCryptoService = null;
+  private Map<TableId,CryptoService> tableCryptoMap;

Review comment:
       Also, we had previously done work in ServerContext to make sure only one 
Crypto Service was created per tserver. If we want to continue this behavior on 
the per table level, we will need to do something like a cache to make sure 
each table only creates one Crypto Service. I am not sure how this could be 
done though as tablets could be spread across different tablet servers. We may 
have to do something in the Manager where the tservers ask for the 
CryptoService per table.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to