keith-turner commented on a change in pull request #2197:
URL: https://github.com/apache/accumulo/pull/2197#discussion_r675628522
##########
File path:
server/base/src/main/java/org/apache/accumulo/server/ServerContext.java
##########
@@ -65,7 +67,8 @@
private DefaultConfiguration defaultConfig = null;
private AccumuloConfiguration systemConfig = null;
private AuthenticationTokenSecretManager secretManager;
- private CryptoService cryptoService = null;
+ private CryptoService walCryptoService = null;
+ private Map<TableId,CryptoService> tableCryptoMap;
Review comment:
> This was an unfinished idea I had to cache the crypto Services in
ServerContext so they don't need to be created every time.
@milleruntime I am looking at this comment in isolation, so my response may
not be applicable. Its possible you could use a configuration Deriver to
create this instead of the Map. Some examples
https://github.com/apache/accumulo/blob/548b037c5917dc1e693733dc3d89599369d79103/server/base/src/main/java/org/apache/accumulo/server/conf/TableConfiguration.java#L269-L275
https://github.com/apache/accumulo/blob/548b037c5917dc1e693733dc3d89599369d79103/server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/Tablet.java#L341-L349
https://github.com/apache/accumulo/blob/548b037c5917dc1e693733dc3d89599369d79103/core/src/main/java/org/apache/accumulo/core/conf/AccumuloConfiguration.java#L525
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
