ctubbsii commented on a change in pull request #2197:
URL: https://github.com/apache/accumulo/pull/2197#discussion_r678556703
##########
File path: core/src/main/java/org/apache/accumulo/core/conf/Property.java
##########
@@ -176,22 +176,6 @@
"One-line configuration property controlling the network locations "
+ "(hostnames) that are allowed to impersonate other users",
"1.7.1"),
- // Crypto-related properties
- @Experimental
- INSTANCE_CRYPTO_PREFIX("instance.crypto.opts.", null, PropertyType.PREFIX,
- "Properties related to on-disk file encryption.", "2.0.0"),
- @Experimental
- @Sensitive
- INSTANCE_CRYPTO_SENSITIVE_PREFIX("instance.crypto.opts.sensitive.", null,
PropertyType.PREFIX,
- "Sensitive properties related to on-disk file encryption.", "2.0.0"),
- @Experimental
- INSTANCE_CRYPTO_SERVICE("instance.crypto.service",
- "org.apache.accumulo.core.spi.crypto.NoCryptoService",
PropertyType.CLASSNAME,
- "The class which executes on-disk file encryption. The default does
nothing. To enable "
- + "encryption, replace this classname with an implementation of the"
- + "org.apache.accumulo.core.spi.crypto.CryptoService interface.",
- "2.0.0"),
-
Review comment:
Yeah, I can see it both ways: "wal" is a tserver feature, but "crypto"
support is an instance feature. I see this as somewhat more closely aligned
with the way volume chooser does things, where it's specified at the system
scope (using `general.` prefix) but a specific implementation could delegate to
per-table config to act in a per-table way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
