milleruntime commented on a change in pull request #2263:
URL: https://github.com/apache/accumulo/pull/2263#discussion_r705291592
##########
File path:
core/src/main/java/org/apache/accumulo/core/spi/compaction/CompactionPlan.java
##########
@@ -55,5 +56,13 @@ Builder addJob(short priority, CompactionExecutorId executor,
CompactionPlan build();
}
+ /**
+ * Return the set of compaction candidates.
+ */
+ Set<CompactableFile> getCandidates();
Review comment:
I was thinking since the `CompactionPlan` is the output of the
`CompactionPlanner`, it would have the candidates in it. But now I see that
`CompactionJob` has files as well. I will drop this from the plan. I am
thinking now, it would be nice to be able to differentiate between the files as
to when `CompactableFile` actually gets selected for compaction. Maybe we could
do something similar to what I did with `TabletFile` and `StoredTabletFile`.
Also, trying to write javadoc for `CompactableFile` made me wonder if we
should make it a self contained collection since you need at least 2 files to
compact them into 1. There shouldn't ever be a single CompactableFile by itself
right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
