milleruntime commented on a change in pull request #2263:
URL: https://github.com/apache/accumulo/pull/2263#discussion_r705451949



##########
File path: 
core/src/main/java/org/apache/accumulo/core/spi/compaction/CompactionPlan.java
##########
@@ -55,5 +56,13 @@ Builder addJob(short priority, CompactionExecutorId executor,
     CompactionPlan build();
   }
 
+  /**
+   * Return the set of compaction candidates.
+   */
+  Set<CompactableFile> getCandidates();

Review comment:
       > There shouldn't ever be a single CompactableFile by itself right?
   
   @EdColeman reminded me of the use case where a user configures the 
`AgeOffFilter` and runs a user compaction to drop old data. Do you know where 
this would occur in CompactableImpl? I can't find it in the new code.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to