keith-turner commented on a change in pull request #2263:
URL: https://github.com/apache/accumulo/pull/2263#discussion_r705486999



##########
File path: 
core/src/main/java/org/apache/accumulo/core/spi/compaction/CompactionPlan.java
##########
@@ -55,5 +56,13 @@ Builder addJob(short priority, CompactionExecutorId executor,
     CompactionPlan build();
   }
 
+  /**
+   * Return the set of compaction candidates.
+   */
+  Set<CompactableFile> getCandidates();

Review comment:
       yeah user initiated compactions will compact a tablet even if it has a 
single file, unless there is a selection plugin that does something else.  The 
following code is called by CompactableImpl and actually does the selection.
   
   
https://github.com/apache/accumulo/blob/77157661af4e6de790e4b0cd34debd02f69bdce2/server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/CompactableUtils.java#L444




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to