dlmarion commented on a change in pull request #2282:
URL: https://github.com/apache/accumulo/pull/2282#discussion_r714013565
##########
File path:
core/src/main/java/org/apache/accumulo/core/util/threads/ThreadPools.java
##########
@@ -189,6 +189,10 @@ public static ThreadPoolExecutor createThreadPool(int
coreThreads, int maxThread
return result;
}
+ /*
+ * If you need the server-side shared ScheduledThreadPoolExecutor, then use
+ * ServerContext.getSharedGenericScheduledExecutorService()
+ */
public static ScheduledThreadPoolExecutor
createGeneralScheduledExecutorService(AccumuloConfiguration conf) {
Review comment:
Not all calls were replaced w/ the new context method. There are places
in the code where the new method
`ThreadPools.createGeneralScheduledExecutorService` did not replace the use of
SimpleTimer. For example, in the
[TabletServerBatchWriter](ThreadPools.createGeneralScheduledExecutorService).
For this change I went back through diff of commit
e62ace6a9d37572d95999f5412c6148efbba50b9 and used the new context method in
places where SimpleTimer was being used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
