ctubbsii commented on pull request #2282: URL: https://github.com/apache/accumulo/pull/2282#issuecomment-926020254
> Another option would be to make the generic scheduled thread pool resize itself in all cases like we are doing [here](https://github.com/apache/accumulo/pull/2282/files#diff-082a1c54b559610df4a2cdcb0bc33144ce21696d487a2af5c00b355ebcf975cbR139), but instead of using the current value of the property, use the # of tasks in the queue. The point of SimpleTimer was to be a trivial implementation for quick uses. I don't think it's worth making something so feature heavy for the use cases SimpleTimer was written for. Changing the default size of the thread pool to a small number greater than 1 could help avoid blocking simple operations. However, it still has the same basic problem that it makes it easy for use to misuse it by not considering the impact of contention with other uses... but those problems might be less obvious and harder to detect if the contention is less consistent because we increased the size. It might be best to simply discourage the use of a "simple" timer with shared resources. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
