dlmarion commented on a change in pull request #2282:
URL: https://github.com/apache/accumulo/pull/2282#discussion_r714049059
##########
File path:
server/tserver/src/main/java/org/apache/accumulo/tserver/session/SessionManager.java
##########
@@ -65,10 +66,10 @@
private final Long expiredSessionMarker = (long) -1;
private final AccumuloConfiguration aconf;
- public SessionManager(AccumuloConfiguration conf) {
- aconf = conf;
- maxUpdateIdle =
conf.getTimeInMillis(Property.TSERV_UPDATE_SESSION_MAXIDLE);
- maxIdle = conf.getTimeInMillis(Property.TSERV_SESSION_MAXIDLE);
+ public SessionManager(ServerContext context) {
+ this.aconf = context.getConfiguration();
Review comment:
So, I think this specific instance is ok. In most cases, the
AccumuloConfiguration being passes is from `context.getConfiguration`. I did
revert a couple of cases where I could not be sure, DistributedWorkQueue and
AssignmentWatcher.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
