dlmarion commented on a change in pull request #2259:
URL: https://github.com/apache/accumulo/pull/2259#discussion_r717936036
##########
File path:
server/base/src/main/java/org/apache/accumulo/server/compaction/FileCompactor.java
##########
@@ -336,7 +340,9 @@ private void compactLocalityGroup(String lgName,
Set<ByteSequence> columnFamilie
boolean inclusive, FileSKVWriter mfw, CompactionStats majCStats)
throws IOException, CompactionCanceledException {
ArrayList<FileSKVIterator> readers = new
ArrayList<>(filesToCompact.size());
- try (TraceScope span = Trace.startSpan("compact")) {
+ Tracer tracer = TraceUtil.getTracer();
+ Span compactSpan =
tracer.spanBuilder("FileCompactor::compact").startSpan();
Review comment:
I attempted to address this with the new TraceUtil.createSpan methods I
added in 89a814b
##########
File path:
server/base/src/main/java/org/apache/accumulo/server/problems/ProblemReports.java
##########
@@ -68,7 +68,7 @@
* is reporting lots of problems, but problem reports can not be processed
*/
private ExecutorService reportExecutor = ThreadPools.createThreadPool(0, 1,
60, TimeUnit.SECONDS,
- "acu-problem-reporter", new LinkedBlockingQueue<>(500),
OptionalInt.empty(), false);
Review comment:
I added the boolean back to the methods (or overloaded methods) and
reverted all of the calls to reduce the noise in the PR in commit 89a814b
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
