dlmarion commented on a change in pull request #2259:
URL: https://github.com/apache/accumulo/pull/2259#discussion_r717940788
##########
File path:
core/src/main/java/org/apache/accumulo/core/clientImpl/ThriftScanner.java
##########
@@ -396,10 +428,17 @@ else if (log.isTraceEnabled())
// because a thread on the server side may still be processing the
timed out continue scan
scanState.scanID = null;
- if (scanState.isolated)
+ if (scanState.isolated) {
+ child2.recordException(e,
Attributes.builder().put("exception.message", e.getMessage())
Review comment:
I have not seen an example where it does it on its own. We certainly
don't *need* to do it everywhere, I just happened to. I could also make a
utility method in TraceUtil to add the Exception to the Span.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
