dlmarion commented on a change in pull request #2259:
URL: https://github.com/apache/accumulo/pull/2259#discussion_r717941141
##########
File path:
core/src/main/java/org/apache/accumulo/core/clientImpl/TabletServerBatchWriter.java
##########
@@ -707,16 +721,24 @@ void queueMutations(final MutationSet mutationsToSend) {
updateUnknownErrors("Error processing mutation set", e);
}
}
- }));
+ });
}
private void addMutations(MutationSet mutationsToSend) {
Map<String,TabletServerMutations<Mutation>> binnedMutations = new
HashMap<>();
- try (TraceScope span = Trace.startSpan("binMutations")) {
+ Span span =
+
TraceUtil.getTracer().spanBuilder("TabletServerBatchWriter::binMutations").startSpan();
+ try (Scope scope = span.makeCurrent()) {
Review comment:
I looked at this, but I'm not sure what would happen if we created a
class that extended Span.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
