dlmarion commented on pull request #2259:
URL: https://github.com/apache/accumulo/pull/2259#issuecomment-931518384


   I re-tested this by doing the following:
   
   1. Started Accumulo with no changes, confirmed via logging that trace is 
disabled.
   2. Started Accumulo after setting `general.opentelemetry.enabled=true` in 
`accumulo.properties`, confirmed via logging that trace is still disabled (the 
autoconfigured jar is not on the classpath)
   3. Started Accumulo after downloading 
`https://search.maven.org/remotecontent?filepath=io/opentelemetry/javaagent/opentelemetry-javaagent/1.6.2/opentelemetry-javaagent-1.6.2-all.jar`
 and putting it into the `lib` directory. Confirmed via logging that trace is 
disabled. The javaagent jar is shaded, so the autoconfigured classes cant be 
loaded.
   4. Uncommented / set the following in `accumulo-env.sh`:
   ```
   ## Optionally setup OpenTelemetry SDK AutoConfigure
   ## See 
https://github.com/open-telemetry/opentelemetry-java/tree/main/sdk-extensions/autoconfigure
   JAVA_OPTS=("${JAVA_OPTS[@]}"
     "-Dotel.traces.exporter=jaeger"
   )
   
   ## Optionally setup OpenTelemetry Java Agent
   ## See https://github.com/open-telemetry/opentelemetry-java-instrumentation 
for more options
   JAVA_OPTS=("${JAVA_OPTS[@]}"
     "-javaagent:${lib}/opentelemetry-javaagent-1.6.2-all.jar"
   )
   ```
   
   Started Jaeger:
   ```
   docker run -d --name jaeger -e COLLECTOR_ZIPKIN_HOST_PORT=:9411 -p 
5775:5775/udp -p 6831:6831/udp -p 6832:6832/udp -p 5778:5778 -p 16686:16686 -p 
14268:14268 -p 14250:14250 -p 9411:9411 jaegertracing/all-in-one:1.25
   ```
   
   Started Accumulo with the `enabled` property set to `true`, the changes to 
`accumulo-env.sh` and the javaagent jar file. Confirmed via Jaeger UI 
(http://localhost:16686/) that traces were showing up.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to