milleruntime commented on a change in pull request #2318:
URL: https://github.com/apache/accumulo/pull/2318#discussion_r731855068
##########
File path:
core/src/main/java/org/apache/accumulo/core/util/compaction/ExternalCompactionUtil.java
##########
@@ -191,20 +200,24 @@ private static ExternalCompactionId
getRunningCompactionId(HostAndPort compactor
* server context
* @return map of compactor and external compaction jobs
*/
- public static Map<HostAndPort,TExternalCompactionJob>
+ public static Map<QueueAndHostAndPort,TExternalCompactionJob>
getCompactionsRunningOnCompactors(ClientContext context) {
- final List<Pair<HostAndPort,Future<TExternalCompactionJob>>> running = new
ArrayList<>();
+ final List<Pair<QueueAndHostAndPort,Future<TExternalCompactionJob>>>
running =
+ new ArrayList<>();
Review comment:
Not necessarily. You have a List of a Pair of QueueAndHostAndPort for
the "running" variable which is confusing and unmanageable. I think
encapsulating all the information in a class would be ideal. Something like
`List<RunningCompaction>` would be better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
