milleruntime commented on a change in pull request #2318:
URL: https://github.com/apache/accumulo/pull/2318#discussion_r738785049



##########
File path: 
core/src/main/java/org/apache/accumulo/core/util/compaction/ExternalCompactionUtil.java
##########
@@ -191,29 +227,28 @@ private static ExternalCompactionId 
getRunningCompactionId(HostAndPort compactor
    *          server context
    * @return map of compactor and external compaction jobs
    */
-  public static Map<HostAndPort,TExternalCompactionJob>
-      getCompactionsRunningOnCompactors(ClientContext context) {
-
-    final List<Pair<HostAndPort,Future<TExternalCompactionJob>>> running = new 
ArrayList<>();
+  public static List<RunningCompaction> 
getCompactionsRunningOnCompactors(ClientContext context) {
+    final List<RunningCompactionFuture> rcFutures = new ArrayList<>();

Review comment:
       I did some initial testing with the Monitor and it looks like the 
`RunningCompaction` objects returned by this method never contains any of the 
juicy `TCompactionStatusUpdate`.  The updates TreeMap is always empty.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to