milleruntime commented on a change in pull request #2318:
URL: https://github.com/apache/accumulo/pull/2318#discussion_r736544581
##########
File path:
server/compactor/src/main/java/org/apache/accumulo/compactor/Compactor.java
##########
@@ -513,7 +512,10 @@ public void run() {
Preconditions.checkState(compactionRunning.compareAndSet(false, true));
try {
LOG.info("Starting up compaction runnable for job: {}", job);
- updateCompactionState(job, TCompactionState.STARTED, "Compaction
started");
+ TCompactionStatusUpdate update = new TCompactionStatusUpdate();
+ update.setState(TCompactionState.STARTED);
+ update.setMessage("Compaction started");
+ updateCompactionState(job, update);
Review comment:
While on the subject of thrift object constructors, I had a question.
What do you think is the best practice for optional types? I couldn't find
anything in the Thrift documentation. As far as I could tell, the only way to
have an optional type is not including it in the constructor and using the
getter/setters.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
