ctubbsii commented on a change in pull request #2321:
URL: https://github.com/apache/accumulo/pull/2321#discussion_r735984094
##########
File path: server/manager/src/main/java/org/apache/accumulo/manager/Manager.java
##########
@@ -1714,6 +1723,11 @@ public boolean isActiveService() {
return managerInitialized.get();
}
+ @Override
+ public boolean isUpgrading() {
+ return managerUpgrading.get();
+ }
Review comment:
I think you could simplify this:
```suggestion
if (!managerInitialized.get()) {
return false;
}
if (managerUpgrading.get()) {
log.warn("Cannot access service while it is upgrading.");
return false;
}
return true;
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
