ctubbsii commented on a change in pull request #2321:
URL: https://github.com/apache/accumulo/pull/2321#discussion_r736010210
##########
File path: server/manager/src/main/java/org/apache/accumulo/manager/Manager.java
##########
@@ -1714,6 +1723,11 @@ public boolean isActiveService() {
return managerInitialized.get();
}
+ @Override
+ public boolean isUpgrading() {
+ return managerUpgrading.get();
+ }
Review comment:
Is the exception a problem? At the very least, it seems safer than
returning `null` in that case. It's not clear what the full implications are
for returning `null`, because doing that makes it appear as though the method
that is being proxied actually got executed and just returned `null`. I think
the exception is fine, so long as there's an explanation for it, and the log
message adds that explanation. But, if there's a problem with the exception...
then maybe we can come up with a different solution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
