Manno15 commented on a change in pull request #2321:
URL: https://github.com/apache/accumulo/pull/2321#discussion_r736013779
##########
File path: server/manager/src/main/java/org/apache/accumulo/manager/Manager.java
##########
@@ -1714,6 +1723,11 @@ public boolean isActiveService() {
return managerInitialized.get();
}
+ @Override
+ public boolean isUpgrading() {
+ return managerUpgrading.get();
+ }
Review comment:
There isn't necessarily a problem with the exception but it can be
misleading, especially at first glance. Even with the additional warning, it is
not clear that they are connected in any way. I do agree that returning `null`
isn't the best solution which is part of the reason I wanted a review to get
more ideas on what the ideal solution would be.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
