ctubbsii commented on a change in pull request #2305:
URL: https://github.com/apache/accumulo/pull/2305#discussion_r739328954
##########
File path: assemble/pom.xml
##########
@@ -470,6 +481,18 @@
<artifactId>jline</artifactId>
<optional>true</optional>
</dependency>
+ <dependency>
+ <groupId>org.latencyutils</groupId>
+ <artifactId>LatencyUtils</artifactId>
+ <version>2.0.3</version>
+ <optional>true</optional>
+ <exclusions>
+ <exclusion>
+ <groupId>org.hdrhistogram</groupId>
+ <artifactId>HdrHistogram</artifactId>
+ </exclusion>
Review comment:
Neither HdrHistogram or LatencyUtils are in [the
micrometer-bom](https://search.maven.org/artifact/io.micrometer/micrometer-bom/1.7.5/pom).
If they were, then the version specified here should merely be removed. Since
they are not, the version needs to be specified in the parent pom. The
exclusion should also be moved to the parent pom. I infer that was done for
dependency convergence.
In any case, I have a fix ready as part of a POM/LICENSE update, but I'm
cleaning up some adjacent spotbugs issues first. No worries.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
