EdColeman commented on a change in pull request #2305:
URL: https://github.com/apache/accumulo/pull/2305#discussion_r736659451
##########
File path:
server/manager/src/main/java/org/apache/accumulo/manager/metrics/fate/FateMetrics.java
##########
@@ -123,16 +123,16 @@ private void update(MeterRegistry registry) {
}
metricValues.getOpTypeCounters().forEach((name, count) -> {
Review comment:
This is not a blocker - just inquiring if we are moving in a consistent
direction. For tag naming - the micrometer docs provide the following guidance.
```
We recommend that you follow the same lowercase dot notation described for
meter names when naming tags. Using this consistent naming convention for tags
allows for better translation into the respective monitoring system’s idiomatic
naming schemes.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
