ctubbsii commented on a change in pull request #2305:
URL: https://github.com/apache/accumulo/pull/2305#discussion_r738528391
##########
File path: assemble/src/main/assemblies/component.xml
##########
@@ -99,10 +100,12 @@
<include>org.glassfish.jersey.inject:jersey-hk2</include>
<include>org.glassfish.jersey.media:jersey-media-jaxb</include>
<include>org.glassfish.jersey.media:jersey-media-json-jackson</include>
+ <include>org.hdrhistogram:HdrHistogram</include>
<include>org.hibernate.validator:hibernate-validator</include>
<include>org.javassist:javassist</include>
<include>org.jboss.logging:jboss-logging</include>
<include>org.jline:jline</include>
+ <include>org.latencyutils:LatencyUtils</include>
Review comment:
When adding new artifacts to our assembly, we need to make sure the
LICENSE/NOTICE files that get bundled into the assembly are also updated to
reflect the new content we are redistributing. micrometer is Apache-2.0, but
HdrHistogram and LatencyUtils are CC0-1.0 or BSD-2-Clause. I'm working on a
fix, but wanted to offer a reminder here in context.
##########
File path: assemble/pom.xml
##########
@@ -470,6 +481,18 @@
<artifactId>jline</artifactId>
<optional>true</optional>
</dependency>
+ <dependency>
+ <groupId>org.latencyutils</groupId>
+ <artifactId>LatencyUtils</artifactId>
+ <version>2.0.3</version>
+ <optional>true</optional>
+ <exclusions>
+ <exclusion>
+ <groupId>org.hdrhistogram</groupId>
+ <artifactId>HdrHistogram</artifactId>
+ </exclusion>
Review comment:
versions and exclusions should be specified in dependency management
section of parent pom. I'm working on a fix, but wanted to offer a reminder
here in context
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
