ctubbsii commented on a change in pull request #2569:
URL: https://github.com/apache/accumulo/pull/2569#discussion_r828450192
##########
File path:
server/base/src/main/java/org/apache/accumulo/server/conf/ServerConfigurationFactory.java
##########
@@ -106,12 +108,7 @@ public synchronized DefaultConfiguration
getDefaultConfiguration() {
@Override
public synchronized AccumuloConfiguration getSystemConfiguration() {
if (systemConfig == null) {
- // Force the creation of a new ZooCache instead of using a shared one.
- // This is done so that the ZooCache will update less often, causing the
- // configuration update count to increment more slowly.
- ZooCache propCache =
- zcf.getNewZooCache(context.getZooKeepers(),
context.getZooKeepersSessionTimeOut());
- systemConfig = new ZooConfiguration(context, propCache,
getSiteConfiguration());
+ systemConfig = new SystemConfiguration(log, context, sysPropCacheId,
getSiteConfiguration());
}
return systemConfig;
Review comment:
I think this is okay for now. This is a direct translation of the
existing code, which was done to avoid ZooCache reuse. Some of these can be
cleaned up after, along with getting rid of ServerConfigurationFactory entirely
(although that part probably can't happen until 3.0).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
