EdColeman commented on a change in pull request #2569:
URL: https://github.com/apache/accumulo/pull/2569#discussion_r829122300
##########
File path:
core/src/main/java/org/apache/accumulo/core/conf/AccumuloConfiguration.java
##########
@@ -597,4 +599,13 @@ public T derive() {
* this configuration.
*/
public void invalidateCache() {}
+
+ /**
+ * get a parent configuration or null if it does not exist.
+ *
+ * @since 2.1.0
+ */
+ public AccumuloConfiguration getParent() {
+ return null;
Review comment:
When would it be appropriate to throw an Exception and what exception
type do you suggest?
The code that uses Accumulo configuration blindly calls getParent to walk up
the hierarchy if it exists. For the existing cases that do not have a parent
(DefaultConfiguration, ConfigurationCopy) there is no parent. In cases like
system, namespace and table, calling getParent returns the next configuration
up the chain. Getting a null indicates that the top of the hierarchy has been
reached and is not an exception. When would an exception be appropriate?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
