milleruntime commented on code in PR #2755:
URL: https://github.com/apache/accumulo/pull/2755#discussion_r890447312
##########
core/src/main/java/org/apache/accumulo/fate/AdminUtil.java:
##########
@@ -390,11 +390,10 @@ private FateStatus getTransactionStatus(ReadOnlyTStore<T>
zs, Set<Long> filterTx
zs.unreserve(tid, 0);
- if ((filterTxid != null && !filterTxid.contains(tid))
- || (filterStatus != null && !filterStatus.contains(status)))
- continue;
-
- statuses.add(new TransactionStatus(tid, status, debug, hlocks, wlocks,
top, timeCreated));
+ if ((filterTxid == null) || filterTxid.contains(tid) || (filterStatus ==
null)
+ || filterStatus.contains(status)) {
+ statuses.add(new TransactionStatus(tid, status, debug, hlocks, wlocks,
top, timeCreated));
+ }
Review Comment:
Just the test on main fails without this change:
<pre>
[ERROR] Failures:
[ERROR] ShellServerIT.testFateCommandWithSlowCompaction:2119 txid: present
in root@miniInstance ShellServerIT_testFateCommandWithSlowCompaction0> fate
-print
0 transactions
was not true ==> expected: <true> but was: <false>
</pre>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
