EdColeman commented on code in PR #2755:
URL: https://github.com/apache/accumulo/pull/2755#discussion_r891268937
##########
core/src/main/java/org/apache/accumulo/fate/AdminUtil.java:
##########
@@ -390,11 +390,10 @@ private FateStatus getTransactionStatus(ReadOnlyTStore<T>
zs, Set<Long> filterTx
zs.unreserve(tid, 0);
- if ((filterTxid != null && !filterTxid.contains(tid))
- || (filterStatus != null && !filterStatus.contains(status)))
- continue;
-
- statuses.add(new TransactionStatus(tid, status, debug, hlocks, wlocks,
top, timeCreated));
+ if ((filterTxid == null) || filterTxid.contains(tid) || (filterStatus ==
null)
+ || filterStatus.contains(status)) {
+ statuses.add(new TransactionStatus(tid, status, debug, hlocks, wlocks,
top, timeCreated));
+ }
Review Comment:
0 was a standing for any txid, could be 1234, whatever. The point was that
specifying a set of txids and a state, then I would expect that it would be an
AND - only the txids that match and only in the state provided.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
