milleruntime commented on code in PR #2755:
URL: https://github.com/apache/accumulo/pull/2755#discussion_r903612637
##########
core/src/main/java/org/apache/accumulo/fate/AdminUtil.java:
##########
@@ -390,17 +388,23 @@ private FateStatus getTransactionStatus(ReadOnlyTStore<T>
zs, Set<Long> filterTx
zs.unreserve(tid, 0);
- if ((filterTxid != null && !filterTxid.contains(tid))
- || (filterStatus != null && !filterStatus.contains(status)))
- continue;
-
- statuses.add(new TransactionStatus(tid, status, debug, hlocks, wlocks,
top, timeCreated));
+ if (includeByStatus(status, filterStatus) && includeByTxid(tid,
filterTxid)) {
Review Comment:
> I thought the discussion centered around the includeByTxid &&
includeByStatus and if that should be an or. The current behavior in this code
is that if you specify txid and a status. both must match. (and both take a
list)
Yes.
I am going to take a look at the new Test today and see if I can come up
with the untested case as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
