cshannon commented on code in PR #2986:
URL: https://github.com/apache/accumulo/pull/2986#discussion_r984487416
##########
core/src/main/java/org/apache/accumulo/core/client/admin/InstanceOperations.java:
##########
@@ -93,6 +93,15 @@ void modifyProperties(Consumer<Map<String,String>>
mapMutator) throws AccumuloEx
*/
Map<String,String> getSystemConfiguration() throws AccumuloException,
AccumuloSecurityException;
+ /**
+ * Retrieves the configured System properties from zookeeper. This method is
different from
+ * {@link #getSystemConfiguration()} as it will only return the configured
properties in zookeeper
+ * and not properties from accumulo.properties or defaults.
+ *
+ * @return a map of system properties set in zookeeper
+ */
+ Map<String,String> getSystemProperties() throws AccumuloException,
AccumuloSecurityException;
Review Comment:
Sure, we can rename it to something else if it makes it easier to
distinguish the the difference as there was confusion around it. I think it's
important to expose the method because with the new API you can mutate multiple
properties at once and it's going to be very useful to query what properties
were set vs what are defaults so the user can know what's been changed, etc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
