dlmarion commented on code in PR #2986:
URL: https://github.com/apache/accumulo/pull/2986#discussion_r984510630
##########
core/src/main/java/org/apache/accumulo/core/client/admin/InstanceOperations.java:
##########
@@ -93,6 +93,15 @@ void modifyProperties(Consumer<Map<String,String>>
mapMutator) throws AccumuloEx
*/
Map<String,String> getSystemConfiguration() throws AccumuloException,
AccumuloSecurityException;
+ /**
+ * Retrieves the configured System properties from zookeeper. This method is
different from
+ * {@link #getSystemConfiguration()} as it will only return the configured
properties in zookeeper
+ * and not properties from accumulo.properties or defaults.
+ *
+ * @return a map of system properties set in zookeeper
+ */
+ Map<String,String> getSystemProperties() throws AccumuloException,
AccumuloSecurityException;
Review Comment:
I'd rather keep `getSystemProperties` vs using `getStoredProperties`. If
someone wants to know the difference, then they can read the javadoc. The word
`stored` doesn't really convey the difference, the user still has to read the
javadoc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
