dlmarion commented on code in PR #3083:
URL: https://github.com/apache/accumulo/pull/3083#discussion_r1025488640
##########
server/base/src/main/java/org/apache/accumulo/server/compaction/FileCompactor.java:
##########
@@ -212,9 +216,21 @@ public CompactionStats call() throws IOException,
CompactionCanceledException {
try {
FileOperations fileFactory = FileOperations.getInstance();
FileSystem ns = this.fs.getFileSystemByPath(outputFile.getPath());
- mfw = fileFactory.newWriterBuilder()
+
+ boolean dropCacheBehindMajcOutput = false;
+ if (!RootTable.ID.equals(this.extent.tableId())
+ && !MetadataTable.ID.equals(this.extent.tableId())
+ && acuTableConf.getBoolean(Property.TABLE_MAJC_OUTPUT_DROP_CACHE)) {
Review Comment:
@keith-turner - I tried looking through new pluggable compaction service
code, I'm thinking it may be possible for someone to implement their own
CompactionConfigurer such that they can set this new property based on the
KeyExtent that is getting compacted. Is that possible? If not, then we may want
to add that functionality in a follow-on commit. I'm thinking of the case where
you have a date sorted table and you may not want to drop the files from the
page cache when compacting recent data, but may want to for older data.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
