ctubbsii commented on code in PR #3083:
URL: https://github.com/apache/accumulo/pull/3083#discussion_r1026054305
##########
core/src/main/java/org/apache/accumulo/core/conf/Property.java:
##########
@@ -964,6 +964,11 @@ public enum Property {
"1.3.5"),
TABLE_ARBITRARY_PROP_PREFIX("table.custom.", null, PropertyType.PREFIX,
"Prefix to be used for user defined arbitrary properties.", "1.7.0"),
+ TABLE_MAJC_OUTPUT_DROP_CACHE("table.compaction.major.output.drop.cache",
"false",
+ PropertyType.BOOLEAN,
+ "Setting this property to true will call"
+ + "FSDataOutputStream.setDropBehind(true) on the major compaction
output stream.",
+ "2.1.1"),
Review Comment:
Do we really need this? Why not just always set it, and let it be cached
when read?
Also, this is a user-facing configuration addition (not strictly public API,
but analogous in terms of forwards/backwards-compatibility issues and user
expectations). We try to avoid those kinds of additions in patch releases. Can
we justify adding it in 2.1.1?
##########
core/src/main/java/org/apache/accumulo/core/file/rfile/RFileOperations.java:
##########
@@ -131,6 +135,20 @@ protected FileSKVWriter openWriter(FileOptions options)
throws IOException {
outputStream = fs.create(new Path(file), false, bufferSize, (short) rep,
block);
}
+ if (options.dropCacheBehind) {
+ // Tell the DataNode that the write ahead log does not need to be cached
in the OS page
+ // cache
Review Comment:
copy / paste error? This isn't a write-ahead log.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
