keith-turner commented on code in PR #3083:
URL: https://github.com/apache/accumulo/pull/3083#discussion_r1026351925


##########
core/src/main/java/org/apache/accumulo/core/conf/Property.java:
##########
@@ -964,6 +964,11 @@ public enum Property {
       "1.3.5"),
   TABLE_ARBITRARY_PROP_PREFIX("table.custom.", null, PropertyType.PREFIX,
       "Prefix to be used for user defined arbitrary properties.", "1.7.0"),
+  TABLE_MAJC_OUTPUT_DROP_CACHE("table.compaction.major.output.drop.cache", 
"false",
+      PropertyType.BOOLEAN,
+      "Setting this property to true will call"
+          + "FSDataOutputStream.setDropBehind(true) on the major compaction 
output stream.",
+      "2.1.1"),

Review Comment:
   If the key extent aware configurer is a compelling feature, then it would 
require a new table prop for the use case @dlmarion outlined.  So I think  the 
decision on adding this prop hinges around whether the configurer change is 
made. From that perspective would it make sense to do both in the same PR?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to