EdColeman commented on code in PR #3184:
URL: https://github.com/apache/accumulo/pull/3184#discussion_r1095069679
##########
server/base/src/main/java/org/apache/accumulo/server/util/SystemPropUtil.java:
##########
@@ -76,13 +76,13 @@ private static String validateSystemProperty(String
property, final String value
if (!Property.isValidZooPropertyKey(property)) {
IllegalArgumentException iae =
new IllegalArgumentException("Zookeeper property is not mutable: " +
property);
- log.error("Encountered error setting zookeeper property", iae);
+ log.debug("Encountered error setting zookeeper property", iae);
Review Comment:
Consider removing or using trace. The error logged by the calling method
should be enough - and usually systems seem to run with logging set to debug
because we do not seem to log enough information at info or above to
adequately troubleshoot issues when they occur. (Which is a whole other topic)
Sorry I was not clearer on my earlier comment.
##########
server/base/src/main/java/org/apache/accumulo/server/util/SystemPropUtil.java:
##########
@@ -76,13 +76,13 @@ private static String validateSystemProperty(String
property, final String value
if (!Property.isValidZooPropertyKey(property)) {
IllegalArgumentException iae =
new IllegalArgumentException("Zookeeper property is not mutable: " +
property);
- log.error("Encountered error setting zookeeper property", iae);
+ log.debug("Encountered error setting zookeeper property", iae);
throw iae;
}
if (!Property.isValidProperty(property, value)) {
IllegalArgumentException iae = new IllegalArgumentException(
"Property " + property + " with value: " + value + " is not valid");
- log.error("Encountered error setting zookeeper property", iae);
+ log.debug("Encountered error setting zookeeper property", iae);
Review Comment:
Please consider trace (see earlier comment)
##########
server/base/src/main/java/org/apache/accumulo/server/util/SystemPropUtil.java:
##########
@@ -100,7 +100,7 @@ private static String validateSystemProperty(String
property, final String value
&& !foundProp.getType().isValidFormat(value)))) {
IllegalArgumentException iae = new IllegalArgumentException(
"Ignoring property " + property + " it is either null or in an
invalid format");
- log.error("Attempted to set zookeeper property. Value is either null or
invalid", iae);
+ log.debug("Attempted to set zookeeper property. Value is either null or
invalid", iae);
Review Comment:
Please consider trace (see earlier comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
