EdColeman commented on code in PR #3184:
URL: https://github.com/apache/accumulo/pull/3184#discussion_r1095086052
##########
server/base/src/main/java/org/apache/accumulo/server/util/SystemPropUtil.java:
##########
@@ -76,13 +76,13 @@ private static String validateSystemProperty(String
property, final String value
if (!Property.isValidZooPropertyKey(property)) {
IllegalArgumentException iae =
new IllegalArgumentException("Zookeeper property is not mutable: " +
property);
- log.error("Encountered error setting zookeeper property", iae);
+ log.debug("Encountered error setting zookeeper property", iae);
Review Comment:
I would be fine with switching them to trace if they are logged by the
calling methods.
A review / overhauling of the logging is probably overdue, but also too
large of a task to handle at one time. One factor is there are down-stream
users that may be processing the logs and it is really difficult to know
exactly what information is important at a given time. Most of the time, it
seems like noise. Until that one time you need to figure out X and then you
start wishing there were more details ;-)
There is a start at unifying things with the
org.apache.accumulo.core.logging.Logging class. Using and extending that could
help reduce the scope of the problem moving forward.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
