ddanielr commented on code in PR #3184:
URL: https://github.com/apache/accumulo/pull/3184#discussion_r1095076041
##########
server/base/src/main/java/org/apache/accumulo/server/util/SystemPropUtil.java:
##########
@@ -76,13 +76,13 @@ private static String validateSystemProperty(String
property, final String value
if (!Property.isValidZooPropertyKey(property)) {
IllegalArgumentException iae =
new IllegalArgumentException("Zookeeper property is not mutable: " +
property);
- log.error("Encountered error setting zookeeper property", iae);
+ log.debug("Encountered error setting zookeeper property", iae);
Review Comment:
I agree that `debug` is commonly used for "general awareness" instead of
`Info`.
So I'm happy to switch to `trace` but I'd like to also switch all instances
of `debug` in SystemPropUtil if they are already logged in their calling
methods.
Outside of this PR, maybe a overhaul of logging should be considered to help
reduce the need for `debug` use in production environments?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
