dlmarion commented on code in PR #3189:
URL: https://github.com/apache/accumulo/pull/3189#discussion_r1099310484
##########
server/base/src/main/java/org/apache/accumulo/server/ServerOpts.java:
##########
@@ -27,6 +28,17 @@ public class ServerOpts extends ConfigOpts {
@Parameter(names = {"-a", "--address"}, description = "address to bind to")
private String address = null;
+ @Parameter(required = false, names = {"-g", "--group"},
+ description = "Optional group name that will be made available to the
client (e.g. ScanServerSelector) "
+ + "and server (e.g. Balancers) plugins. If not specified will be
set to '"
+ + ServiceLockData.ServiceDescriptor.DEFAULT_GROUP_NAME
+ + "'. Assigning servers to groups support dedicating server
resources for specific purposes, where supported.")
+ private String groupName =
ServiceLockData.ServiceDescriptor.DEFAULT_GROUP_NAME;
Review Comment:
Does the current configuration mechanism support shell interpolation for
configuration values? For example, could you put the following in
`accumulo.properties`?
```
tserver.address.listen=$(hostname -i)`
```
If so, then this makes sense to me. If not, then I don't think anyone would
want to put the bind address in a config file, as that would cause different
`accumulo.properties` files on every host. At least by putting in on the
command line you can use CLI commands to get the IP address and pass that in as
the argument value. It even works in
[k8s](https://github.com/dlmarion/accumulo-k8s/blob/main/accumulo-tserver.yaml#L23)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
