EdColeman commented on PR #3189: URL: https://github.com/apache/accumulo/pull/3189#issuecomment-1428140608
I general this looks like a good change. It may help if the internal representations of the lock data were more encapsulated so that the storage type was not visible outside of the LockData. Looking at how to handle tservers and other processes that have locks when an upgrade occurs, one improvement could be if the lock data included either the data version or maybe the release version. While added either of those at this point would be out of scope for this PR, designing it so that it is easier to extend could help limit changes in the future. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
