ctubbsii commented on code in PR #3189:
URL: https://github.com/apache/accumulo/pull/3189#discussion_r1099829455
##########
server/base/src/main/java/org/apache/accumulo/server/ServerOpts.java:
##########
@@ -27,6 +28,17 @@ public class ServerOpts extends ConfigOpts {
@Parameter(names = {"-a", "--address"}, description = "address to bind to")
private String address = null;
+ @Parameter(required = false, names = {"-g", "--group"},
+ description = "Optional group name that will be made available to the
client (e.g. ScanServerSelector) "
+ + "and server (e.g. Balancers) plugins. If not specified will be
set to '"
+ + ServiceLockData.ServiceDescriptor.DEFAULT_GROUP_NAME
+ + "'. Assigning servers to groups support dedicating server
resources for specific purposes, where supported.")
+ private String groupName =
ServiceLockData.ServiceDescriptor.DEFAULT_GROUP_NAME;
Review Comment:
We use commons-configuration2, which does support property interpolation,
but not exactly like your example. You can do something like
`tserver.address.listen=${env:HOSTNAME}` and in in your environment, you can do
`HOSTNAME=$(hostname -i)` (for example, in `accumulo-env.sh` or `.bashrc`).
We also support setting any of our configuration properties on the
command-line to override what's in the config file. So, instead of `-a
$(hostname -i)`, you could do `-o tserver.address.listen=$(hostname -i)`, so
you don't need to have the address hard-coded in the config file, and can set
it dynamically on the command-line, even though it's a configuration file
property. This feature was specifically added in 2.0 to support container
deployments.
For the address, that would depend on us actually having a configuration
property for the listen/bind address to replace `-a`, which we currently do not
have (`tserver.address.listen` was merely an example). But, that's the
direction I think we should go; for the purposes of this issue, I think the
addition of the group should follow the direction of making it a configuration
property, instead of the old precedent of `-a`. We have a complete
configuration mechanism with a lot of flexibility already, so we shouldn't need
to add one-off command-line options outside that configuration mechanism, like
`-g` (and we should eventually get rid of the other one-off command-line
options like `-a`, but that's for another ticket).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
