cshannon commented on code in PR #3401: URL: https://github.com/apache/accumulo/pull/3401#discussion_r1198874844
########## core/src/main/java/org/apache/accumulo/core/metadata/AbstractTabletFile.java: ########## @@ -0,0 +1,44 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * https://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.accumulo.core.metadata; + +import java.util.Objects; + +import org.apache.hadoop.fs.Path; + +public abstract class AbstractTabletFile<T extends AbstractTabletFile<T>> implements Comparable<T> { Review Comment: That's an interesting idea, I also have talked to @EdColeman a bit about #2830 and I do plan to address that problem as well in another PR. I think either having StoredTabletFile become a sibling to TabletFile or have StoredTabledFile contain a TabletFile (similar to the Location fix in #3257) instead of using inheritance could help us solve the issue but I will experiment with this a bit and see. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
