keith-turner commented on code in PR #3401:
URL: https://github.com/apache/accumulo/pull/3401#discussion_r1199122626
##########
core/src/main/java/org/apache/accumulo/core/metadata/TabletFile.java:
##########
@@ -155,4 +142,9 @@ public int hashCode() {
public String toString() {
return normalizedPath;
}
+
+ public static TabletFile of(final Path path) {
Review Comment:
> Constructors are not very descriptive which is annoying. If you have 10
different constructors they are all called the same thing (class name) with
different arguments so it's not always clear the difference at first glance.
That is a good reason for using static methods instead of constructors, I
like that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
