cshannon commented on code in PR #3401:
URL: https://github.com/apache/accumulo/pull/3401#discussion_r1198887028
##########
server/base/src/main/java/org/apache/accumulo/server/fs/FileManager.java:
##########
@@ -94,12 +93,12 @@ public boolean equals(Object obj) {
@Override
public int hashCode() {
- return fileName.hashCode();
+ return file.hashCode();
}
}
- private Map<String,List<OpenReader>> openFiles;
- private HashMap<FileSKVIterator,String> reservedReaders;
+ private Map<TabletFile,List<OpenReader>> openFiles;
Review Comment:
Agree that this should be fine in this case (both objects resolve to the
same equals anyways) but we will definitely need to make sure things don't
break when #2380 is fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
