EdColeman commented on code in PR #3551:
URL: https://github.com/apache/accumulo/pull/3551#discussion_r1245443812
##########
core/src/main/java/org/apache/accumulo/core/metrics/MetricsUtil.java:
##########
@@ -121,6 +121,15 @@ public static List<Tag> getCommonTags() {
return commonTags;
}
+ // Centralize any specific string formatting for metric names and/or tags.
Review Comment:
This seems confusing. The micrometer convention is to use dots in the name
and then have conversion done by the monitoring system (see
https://micrometer.io/docs/concepts#_naming_meters) Maybe just clarifying the
javadoc for usage? Otherwise, it seems counter to the micrometer convention
and recommendations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
