ddanielr commented on code in PR #3551:
URL: https://github.com/apache/accumulo/pull/3551#discussion_r1256589520
##########
core/src/main/java/org/apache/accumulo/core/metrics/MetricsUtil.java:
##########
@@ -121,6 +121,15 @@ public static List<Tag> getCommonTags() {
return commonTags;
}
+ // Centralize any specific string formatting for metric names and/or tags.
Review Comment:
I agree that micrometer wants dot separation and full lowercase strings.
The dot removal was due to confusion about our current naming conventions as
there are metric labels in MetricsProducer that use a underscore separator. I'm
creating a different PR to sort that out.
My intent with this method is to use it to normalize any internal accumulo
object names that we use for labels to the micrometer standard.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
