ddanielr commented on PR #3551: URL: https://github.com/apache/accumulo/pull/3551#issuecomment-1626351497
> In general - why are the metric changes being testing in BulkNewIT? Would it be better if the test was a stand-alone test of the metrics? If a package does not exist, in may be desirable to have a metrics specific sub-package for metric IT tests so that they are easier to find? I was testing this in BulkNewIT as I knew that the compaction operations would trigger and metrics would be generated. This was done as a convenience to get these metrics generated quickly. However, I need to add more deliberate tests for these metrics to ensure the gauges are being set to correct values. Right now it's just collecting metrics with the specified prefix and putting them into the log. I'm not sure about how to best organize the metric tests so I'd be happy to discuss the best options there. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
